Skip to content

.NET 11 Preview 5#12732

Open
gewarren wants to merge 7 commits into
dotnet:mainfrom
gewarren:net11-pre5-chunked
Open

.NET 11 Preview 5#12732
gewarren wants to merge 7 commits into
dotnet:mainfrom
gewarren:net11-pre5-chunked

Conversation

@gewarren

Copy link
Copy Markdown
Contributor

Fixes #12306.

(View by commit.)

Copilot AI review requested due to automatic review settings June 10, 2026 21:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

<Docs>
<summary>
Specifies whether the <see cref="T:System.Threading.RateLimiting.FixedWindowRateLimiter" /> automatically refreshes counters or if someone else
Specified whether the <see cref="T:System.Threading.RateLimiting.FixedWindowRateLimiter" /> is automatically refresh counters or if someone else

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check where this is coming from.

<typeparam name="TPartitionKey">The type to distinguish partitions with.</typeparam>
<param name="partitioner">Method called every time an Acquire or AcquireAsync call is made to determine which rate limiter to apply to the request.
If the <see cref="P:System.Threading.RateLimiting.RateLimitPartition`1.PartitionKey" /> matches a cached entry, then the rate limiter previously used for that key is used. Otherwise, the factory is called to get a new rate limiter.</param>
<param name="partitioner">Method called every time an Acquire or WaitAsync call is made to figure out what rate limiter to apply to the request.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

<Docs>
<summary>
Disposes the lease. This might free up space on the limiter implementation the lease came from.
Dispose the lease. This may free up space on the limiter implementation the lease came from.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

<summary>
Specifies whether the <see cref="T:System.Threading.RateLimiting.SlidingWindowRateLimiter" /> automatically replenishes request counters or if someone else
will be calling <see cref="M:System.Threading.RateLimiting.SlidingWindowRateLimiter.TryReplenish" /> to replenish request counters.
Specified whether the <see cref="T:System.Threading.RateLimiting.SlidingWindowRateLimiter" /> is automatically replenishing request counters or if someone else

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAme.

<Docs>
<summary>
Specifies whether the <see cref="T:System.Threading.RateLimiting.TokenBucketRateLimiter" /> automatically replenishes tokens or if someone else
Specified whether the <see cref="T:System.Threading.RateLimiting.TokenBucketRateLimiter" /> is automatically replenishing tokens or if someone else

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAme.


-or-

<paramref name="registryRights" /> specifies an invalid value.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is whitespace being added?

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish .NET 11 Preview 5 APIs

3 participants